----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101362/#review3324 -----------------------------------------------------------
main-widget.cpp <http://git.reviewboard.kde.org/r/101362/#comment2794> Mem leak over here, please parent the QLabel to something so that it gets deleted after the dialog is closed. And logically this should come *after* you allocate memory to the KDialog. main-widget.cpp <http://git.reviewboard.kde.org/r/101362/#comment2795> I'm being pedantic here, but shouldn't this be following the coding style with the rest of KDE? i.e: connect(obeject1, SIGNAL(foo()), object2, SLOT(bar())); main-widget.cpp <http://git.reviewboard.kde.org/r/101362/#comment2796> Likewise here main-widget.cpp <http://git.reviewboard.kde.org/r/101362/#comment2797> And here ... main-widget.cpp <http://git.reviewboard.kde.org/r/101362/#comment2798> Is this intentional? - Rohan On May 14, 2011, 4:24 p.m., Tarun Mall wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101362/ > ----------------------------------------------------------- > > (Updated May 14, 2011, 4:24 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > This patch will check if no accounts will be present then an dialog box will > be opened telling no accounts found and giving an option to create on. > > > Diffs > ----- > > main-widget.h 7a5e417 > main-widget.cpp 20e8003 > > Diff: http://git.reviewboard.kde.org/r/101362/diff > > > Testing > ------- > > I tested this patch with > 1. No accounts > 2. Creating one account > 3. Deleting that account and then creating one again. > > > Thanks, > > Tarun > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
