> On May 24, 2011, 1:30 p.m., George Goldberg wrote: > > See the inline comments, but essentially I think either the icon name needs > > to be fixed (to be available instead of online) or it needs to be special > > cased in the applet, since lying about what the presence string is will > > break any code that is Telepathy spec compliant.
Ok, i'll make it a special case in the applet for now. - Francesco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101432/#review3477 ----------------------------------------------------------- On May 24, 2011, 1:20 p.m., Francesco Nwokeka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101432/ > ----------------------------------------------------------- > > (Updated May 24, 2011, 1:20 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Changed the text used to rappresent the availability of an account to > "online". This because the presence plasmoid needs to set an icon according > to the parameter "PresenceType". The kde presence icons don't have an icon > "user-available" but there is a "user-online" icon. > All other presence types are correct > > > Diffs > ----- > > presencesource.cpp 5994cac > setrequestedpresencejob.cpp cf21d96 > > Diff: http://git.reviewboard.kde.org/r/101432/diff > > > Testing > ------- > > Used the new presence plasmoid to do the testing. All went well > > > Thanks, > > Francesco > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
