> On May 30, 2011, 10:40 a.m., Dario Freddi wrote: > > The changes are fine - I simply do not understand why you are disabling all > > the streamtubes job. Any particular reason for that?
Because they still need porting to tpqt4 0.5 - I'm doing it one part at a time, so disabled them from building until they are ported in a later patch :) > On May 30, 2011, 10:40 a.m., Dario Freddi wrote: > > CMakeLists.txt, line 6 > > <http://git.reviewboard.kde.org/r/101441/diff/2/?file=18076#file18076line6> > > > > Is this intended? Any special reason for bumping the requirement to KDE > > 4.7 here? Yes, this code won't work with any older nepomuk versions. - George ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101441/#review3591 ----------------------------------------------------------- On May 26, 2011, 3:31 p.m., George Goldberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101441/ > ----------------------------------------------------------- > > (Updated May 26, 2011, 3:31 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > This patch ports the "core" of the telepathy-kde library to current > tpqt4/nepomuk/kde versions. Those parts of the library that are ported should > now be 100% functional (and all the unit tests currently pass for me). This > does not include the KJobs and UI components - these are to come in a later > patch once this one has been merged (they are commented out in the build > scripts for now). > > > Diffs > ----- > > CMakeLists.txt a9b19c4924df10ccc45c1e86506394248b6adb75 > cmake/modules/FindTelepathyQt4.cmake > 14b568b99218e9883e1da691aa2057aa110cdd10 > src/CMakeLists.txt 937aee6ad004d957810e870461b6fd503c5ec589 > src/core/contact.cpp 1402511b889757a19fb1499b1924b7d39fb8387b > src/core/everyone-person-set.cpp 04163cb855e1a981121c1b1fefabad4533ec83f5 > src/core/people-manager.cpp 7d70aafa3e1882c742d2928545b9bf54a0c3c749 > src/core/person.cpp c6ee0d4be594b811885377fd483bcf2b959f7d16 > tests/CMakeLists.txt e2e7cc260bbc8ba0a21127da84f15f5d473a29b8 > tests/entity-test.h 52ac4d28eaa06518d7cb20e2c4f6d0f72696c757 > tests/entity-test.cpp 82b5f390dd4a1586d95a553e6678292f3cc15f03 > tests/everyone-person-set-test.h 1189db863c5c777d62d6824a0fad5ecf6d3eb2f4 > tests/everyone-person-set-test.cpp 817600e1b1ccb1a2f4a03851c2e45689e5bd9fe4 > tests/people-manager-test.h c643bbd34b1a43ceb111bdcb60643e86d56258cf > tests/people-manager-test.cpp c530c15100392168296997b40591bf197a27e447 > tests/person-set-test.h 21b0a3ae5718c4a073a4b6bd4814debcad42ee72 > tests/person-set-test.cpp e04b763f0f0086a22b16e03169b36afa5f730204 > tests/simple-person-set-test.h eaecda9b44acb22269d51f1268b4385613e4186b > tests/simple-person-set-test.cpp a57f8515e2939dc33d0e74e2fd38ab0905ecf4a0 > > Diff: http://git.reviewboard.kde.org/r/101441/diff > > > Testing > ------- > > All unit tests pass for me. > > > Thanks, > > George > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
