----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101479/#review3611 -----------------------------------------------------------
app/chat-window.cpp <http://git.reviewboard.kde.org/r/101479/#comment3022> nextTabAction->setShortcut(KStandardShortcut::tabNext()); This will use the shortcut configured globally in systemsettings. app/chat-window.cpp <http://git.reviewboard.kde.org/r/101479/#comment3023> same as above app/chat-window.cpp <http://git.reviewboard.kde.org/r/101479/#comment3021> currIndex++ makes no sense. You've already added one to it on line 232. If I understand correctly by using currIndex++; it will add one to it after setCurrentIndex is finished, but currIndex is never used afterwards so it's just a waste. - David On June 1, 2011, 9:27 a.m., Francesco Nwokeka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101479/ > ----------------------------------------------------------- > > (Updated June 1, 2011, 9:27 a.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Added keyboard shortcuts to the chat handler for switching tabs. If you have > more than one tab, you can now switch through tabs with the "previous" and > "next" tab shortcut. > These shortcuts are not present in the standard shortcuts so I had to create > them manually > > > This addresses bug 272473. > http://bugs.kde.org/show_bug.cgi?id=272473 > > > Diffs > ----- > > app/chat-window.h f9c07da > app/chat-window.cpp 149608d > > Diff: http://git.reviewboard.kde.org/r/101479/diff > > > Testing > ------- > > opened 5 tabs and switched through them from different positions > > > Thanks, > > Francesco > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
