----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101488/#review3630 -----------------------------------------------------------
This review has been submitted with commit d9d6c7cfa54bffc0996844244d712ea0d82c74b1 by Martin Klapetek. - Commit On June 1, 2011, 10:59 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101488/ > ----------------------------------------------------------- > > (Updated June 1, 2011, 10:59 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > As suggested by oggis, the account->becomeReady() is useless there -- > > <oggis_> void MainWidget::onNewAccountAdded(const Tp::AccountPtr& account) > <oggis_> { Tp::PendingReady *ready = account->becomeReady(); > <oggis_> why, although you have an account factory with a lot of features > including FeatureCore set up for the account manager? > <oggis_> that means that any account signaled to you using newAccount will > have becomeReady with those features already called > <oggis_> (and finished) > <oggis_> that's your AccountManager::newAccount handler > <oggis_> in which you're calling becomeReady(), which means "give me an > operation which emits finished() when Account::FeatureCore is ready on the > account" > <oggis_> although by passing Account::FeatureCore in the factory, you already > say to the library "prepare FeatureCore for all accounts before signaling > them to me in the first place" > > > Diffs > ----- > > main-widget.h 96f228e > main-widget.cpp 4b6c248 > > Diff: http://git.reviewboard.kde.org/r/101488/diff > > > Testing > ------- > > Everything works. > > > Thanks, > > Martin > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
