----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101564/#review3826 -----------------------------------------------------------
Ship it! As a part1, that's absolutely fine. I would suggest doing part 2 before merging, otherwise you'll get loads of bug reports "This button doesn't work" app/chat-window.cpp <http://git.reviewboard.kde.org/r/101564/#comment3108> Might be worth calling all these slots onSomethingSomethingTriggered instead of a fix of triggered and toggled. - David On June 10, 2011, 12:57 p.m., Francesco Nwokeka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101564/ > ----------------------------------------------------------- > > (Updated June 10, 2011, 12:57 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > First patch out of 3 that adds the toolbuttons to the chat window. > The buttons added are actions to start : file transfer + start video call + > start audio call (+ separator) > > // TODO > part2 : connect these buttons > part3 : enable/disable them depending on if the contact supports them > > > Diffs > ----- > > app/chat-window.h 010eea2 > app/chat-window.cpp 59c2e9c > > Diff: http://git.reviewboard.kde.org/r/101564/diff > > > Testing > ------- > > > Thanks, > > Francesco > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
