----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101622/#review3888 -----------------------------------------------------------
Few minor things to sort out. app/CMakeLists.txt <http://git.reviewboard.kde.org/r/101622/#comment3181> Make sure you add this file to git. You probably haven't yet, which is why it's not in the review. app/chat-window.h <http://git.reviewboard.kde.org/r/101622/#comment3184> Nothing uses this, making the whole enum a bit pointless. app/chat-window.cpp <http://git.reviewboard.kde.org/r/101622/#comment3183> What happens in multi-user chats? I think this returns an invalid contact. I think we need to: 1) only enable the buttons if there is a single contact mode. (for now) 2) Double check on the start of startFileTransfer startXyz that contact exists. app/chat-window.cpp <http://git.reviewboard.kde.org/r/101622/#comment3182> Delete these 3 lines. Look up kfiledialog:/// here http://api.kde.org/4.x-api/kdelibs-apidocs/kfile/html/classKFileWidget.html#a347b2860d7fbc35244ed0375bfd6e401 use this as the first parameter of KFileDialog::getOpenFileName. If you copied and pasted this code, patch that too. - David On June 14, 2011, 9:06 p.m., Francesco Nwokeka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101622/ > ----------------------------------------------------------- > > (Updated June 14, 2011, 9:06 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Patch 2 of 3. > This patch connects the buttons with the corrisponding signals. It also > implements a plasma notification system to notify the user on errors given by > these buttons (took procedure from martin's contactlist). > Buttons implemented are : > ~ video call > ~ audio call > ~ send file > > The invite to chat button will remain disabled (from next patch) until group > support will be ok. After these three patches i will work on that feature > again. > > > Diffs > ----- > > app/CMakeLists.txt dd1a23a > app/chat-window.h 3db916e > app/chat-window.cpp 7fe5f51 > > Diff: http://git.reviewboard.kde.org/r/101622/diff > > > Testing > ------- > > Used the buttons to start the different channels and got errors for all apart > for the file transfer because other features are not implemented. Plasma > norification worked well. > > > Thanks, > > Francesco > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
