> On June 22, 2011, 11:30 p.m., Daniele Elmo Domenichelli wrote: > > contact-model-item.cpp, lines 197-208 > > <http://git.reviewboard.kde.org/r/101729/diff/1/?file=24897#file24897line197> > > > > Is there a reason why you are not using > > mPriv->mContact->capabilities().fileTransfer() here?
Probably not, I simply copied and pasted what was there before. I'll use it. > On June 22, 2011, 11:30 p.m., Daniele Elmo Domenichelli wrote: > > contact-model-item.cpp, lines 60-62 > > <http://git.reviewboard.kde.org/r/101729/diff/1/?file=24897#file24897line60> > > > > I don't know if they can change, but perhaps you should connect also > > capabilitiesChanged from self contact... yeah, I thought about it - from what I remember mission control doesn't update till you restart it, so I don't think it could change without plenty of other things going wrong in the meantime. I may as well add it. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101729/#review4083 ----------------------------------------------------------- On June 22, 2011, 7:38 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101729/ > ----------------------------------------------------------- > > (Updated June 22, 2011, 7:38 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Only list audio/video/file capability on a contact if selfContact can support > it. > > > Diffs > ----- > > contact-model-item.h 772becdfd1b98a51e1adfc815485b17e5256b851 > contact-model-item.cpp f9fb80d065a958682a6bc58e510dc975ee518fc8 > > Diff: http://git.reviewboard.kde.org/r/101729/diff > > > Testing > ------- > > Opened contact list, checked that I don't have audio/video listed without > KCall installed. > Same code was used in the chat window apparently file transfer listing works > too. > > > Thanks, > > David > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
