----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101757/#review4153 -----------------------------------------------------------
you're missing latest code from master. Please update your patch to the code in master lib/adium-theme-view.h <http://git.reviewboard.kde.org/r/101757/#comment3396> line up lib/adium-theme-view.cpp <http://git.reviewboard.kde.org/r/101757/#comment3397> 4 spaces indentation lib/chat-text-edit.h <http://git.reviewboard.kde.org/r/101757/#comment3398> line up lib/chat-text-edit.cpp <http://git.reviewboard.kde.org/r/101757/#comment3399> coding standards wants conditions like this if (asdasd) { // some awesome code } else { // other code } lib/chat-text-edit.cpp <http://git.reviewboard.kde.org/r/101757/#comment3400> check coding standards here as well - Francesco On June 25, 2011, 10:54 a.m., Lasath Fernando wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101757/ > ----------------------------------------------------------- > > (Updated June 25, 2011, 10:54 a.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Created a new signal in ChatTextEdit and a new slot in AdiumThemeView. > > Used them to proxy the QKeyEvents for Page Up and Page Down to chatArea. > > > This addresses bug https://bugs.kde.org/show_bug.cgi?id=270717. > > http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=270717 > > > Diffs > ----- > > app/chat-window.cpp 0e6094a > lib/adium-theme-view.h d7c6cb2 > lib/adium-theme-view.cpp 2211cfa > lib/chat-text-edit.h 4f553da > lib/chat-text-edit.cpp 4c3a4c0 > lib/chat-widget.h 06e98a1 > lib/chat-widget.cpp 89e8c97 > > Diff: http://git.reviewboard.kde.org/r/101757/diff > > > Testing > ------- > > Chatted with a friend. > > Hit PgUp/Down. > > > Thanks, > > Lasath > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
