----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101822/#review4299 -----------------------------------------------------------
Ship it! I'd like one change made - unless you can really argue the case for doing it your way. lib/chat-widget.cpp <http://git.reviewboard.kde.org/r/101822/#comment3527> I would much rather use (message.sender()==0) That way we catch 1-1 cases where sender is zero, and use all the information available if some group chats do have all the information (like MSN may well be) - David On July 2, 2011, 1:08 a.m., Francesco Nwokeka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101822/ > ----------------------------------------------------------- > > (Updated July 2, 2011, 1:08 a.m.) > > > Review request for Telepathy. > > > Summary > ------- > > This patch fixes a chat handler crash when in a group chat because "sender" > was null. It also adds info from delivery reports > > > Diffs > ----- > > app/main.cpp 4f47e18 > lib/chat-widget.cpp d427ac1 > > Diff: http://git.reviewboard.kde.org/r/101822/diff > > > Testing > ------- > > > Thanks, > > Francesco > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
