----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101862/#review4480 -----------------------------------------------------------
Ship it! Looks really good to me. - David On July 6, 2011, 5:55 p.m., Lasath Fernando wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101862/ > ----------------------------------------------------------- > > (Updated July 6, 2011, 5:55 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Okay, internet's really sketchy here - I don't have time to type a long > description. > > I'm not sure I handled the result from KMenu::exec() right, but apart form > that my changes *should* be fairly straightforward in the diff. > > http://quickgit.kde.org/?p=clones%2Ftelepathy-chat-handler%2Ffernando%2FdetachableTabs.git&a=shortlog&h=refs/heads/refractored_tabs > > > Diffs > ----- > > app/chat-tab.h 2175fe2 > app/chat-tab.cpp 23c912e > app/chat-window.h 2b2b70d > app/chat-window.cpp 517b694 > app/telepathy-chat-ui.h 306912d > app/telepathy-chat-ui.cpp 1654a9d > > Diff: http://git.reviewboard.kde.org/r/101862/diff > > > Testing > ------- > > Detached a few conversations with friends. > > > Thanks, > > Lasath > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
