----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101992/#review4809 -----------------------------------------------------------
Ship it! Nicely done, thanks! account-button.cpp <http://git.reviewboard.kde.org/r/101992/#comment4183> This comment should probably be on top of the method "presenceDisplayString()" - Martin On July 18, 2011, 12:17 a.m., Paolo Capriotti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101992/ > ----------------------------------------------------------- > > (Updated July 18, 2011, 12:17 a.m.) > > > Review request for Telepathy. > > > Summary > ------- > > * Factored out a function to get the correct action corresponding to the > current presence. > * Use status first for matching, then type if status fails. > * Use 'away' icon for the BRB action. > * Remove unused code. > > > Diffs > ----- > > account-button.h fb98a0d0de34565fb0c92ccd76b737be970ba134 > account-button.cpp 7763858d2705e9afb61a196f392eafebc63b09c7 > > Diff: http://git.reviewboard.kde.org/r/101992/diff > > > Testing > ------- > > tested with gabble > > > Thanks, > > Paolo > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
