> On July 22, 2011, 9:24 a.m., George Kiagiadakis wrote: > > account-button.cpp, line 123 > > <http://git.reviewboard.kde.org/r/102023/diff/4/?file=27661#file27661line123> > > > > This object is leaked. Why not create it on the stack instead?
Uhh, good catch. Maxime, can you please turn it into stack variable? Then just ping me on irc and I'll do a quick review. Thanks. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102023/#review4959 ----------------------------------------------------------- On July 20, 2011, 8:04 p.m., Maxime Corteel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102023/ > ----------------------------------------------------------- > > (Updated July 20, 2011, 8:04 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Added a title to the account presence menu showing the account displayName > > > Diffs > ----- > > account-button.cpp 5c9e135 > > Diff: http://git.reviewboard.kde.org/r/102023/diff > > > Testing > ------- > > Changed status > > > Screenshots > ----------- > > Menu with title > http://git.reviewboard.kde.org/r/102023/s/208/ > With elision > http://git.reviewboard.kde.org/r/102023/s/209/ > > > Thanks, > > Maxime > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
