> On July 25, 2011, 11:02 a.m., George Goldberg wrote: > > src/ui/person-set-model-declarative-wrapper.h, line 1 > > <http://git.reviewboard.kde.org/r/102081/diff/1/?file=29770#file29770line1> > > > > Please can you rename this file and class to be EveryonePersonSetModel, > > since that reflects more accurately what it actually is. > > > > Also, correct the copyright. Did you copy-paste it from code that was > > (C) Collabora? If so leave Collabora there, but if you made any > > modifications that were more than just trivial, add yourself as a copyright > > holder too.
Or you could call it EveryoneModel if you want, although I think EveryonePersonSetModel is probably better since it makes the inheritance explicit in the name. - George ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102081/#review5079 ----------------------------------------------------------- On July 25, 2011, 10:34 a.m., Francesco Nwokeka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102081/ > ----------------------------------------------------------- > > (Updated July 25, 2011, 10:34 a.m.) > > > Review request for Telepathy, George Goldberg and David Edmundson. > > > Summary > ------- > > A patch to enable reading info from the nepomuk model via QML > > > Diffs > ----- > > CMakeLists.txt 0a58700 > src/CMakeLists.txt b0cf53b > src/declarative/CMakeLists.txt PRE-CREATION > src/declarative/declarativeplugins.h PRE-CREATION > src/declarative/declarativeplugins.cpp PRE-CREATION > src/declarative/qmldir PRE-CREATION > src/ui/person-set-model-declarative-wrapper.h PRE-CREATION > src/ui/person-set-model-declarative-wrapper.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/102081/diff > > > Testing > ------- > > This patch works with basic contact list plasmoid in the works in my scratch > repo. > > > Thanks, > > Francesco > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
