----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102484/#review6152 -----------------------------------------------------------
Ship it! Looking good. I wonder what it does for other than KWin window managers though... app/telepathy-chat-ui.cpp <http://git.reviewboard.kde.org/r/102484/#comment5431> Probably could use break; after the channel was found to save some cycles. - Martin On Aug. 29, 2011, 8:33 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102484/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2011, 8:33 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Force window to be raised if a special hint is set in the channel request. > > This is to be used as a workaround to > https://bugs.kde.org/show_bug.cgi?id=275266 > > The forceWindowActive() method is a bit naughty, and unsafe to just casually > start inserting into the code. Especially with the TextUi sometimes ensuring > channels back on itself. > > This allows us to work round the issue by allowing the Contact List (or > anyone else who wanted it) to tell the TextUi that it's ok to force itself on > top of the other windows. > > There is a companion update for the contact list to set this hint when > creating text channels. > > In doing this I uncovered a bug in TpQt4 - this is going to be fixed, > probably in a release tomorrow. > > > Diffs > ----- > > app/telepathy-chat-ui.h 3d2001588a073215fe90d3816d5b9ab8c3cd2144 > app/telepathy-chat-ui.cpp 5473394ef4020bf4f02f304296df9214a18d988a > > Diff: http://git.reviewboard.kde.org/r/102484/diff > > > Testing > ------- > > > Thanks, > > David > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
