----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102535/#review6284 -----------------------------------------------------------
The font change itself is great, however this patch reverts some recent changes - you don't have to loop over the actions to find the current one, you already have it there (line 219 in the original), so just use that QAction and remove the foreach loop and leave only the font changing. Also watch for whitespaces ;) - Martin On Sept. 5, 2011, 5:45 p.m., Rohan Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102535/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2011, 5:45 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Currently if you choose a status, there's no way to figure out what your > status is via the contact list, this patch adds a feature where the current > status is italicized and shown in bold letters > > > Diffs > ----- > > account-button.cpp e4278a1 > > Diff: http://git.reviewboard.kde.org/r/102535/diff > > > Testing > ------- > > I'm still trying to get telepathy kde to work, but i think this should work, > please test rigorously before approving this patch! > > > Thanks, > > Rohan > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
