----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102306/ -----------------------------------------------------------
(Updated Sept. 7, 2011, 6:44 p.m.) Review request for Telepathy and David Edmundson. Changes ------- Fixed all the issues found by George. I didn't remove the context->setFinishedWithError branch but instead I decremented again the job counter, so that the next time it returns -1, I'm not sure though if this is a real issue and if can be solved in this way. A mutex would probably be better... Suggestions? Summary ------- To handle metadata we will need another Tp::AbstactClientHandler for streamtubes, therefore it's not good to use the FileTransferHandler class to control the whole program This patch adds a new class (FileTransferControl) that works almost like a singleton (without using K_GLOBAL_STATIC that doesn't work for QObjects) and moves control of the flow of the program into this class. Diffs (updated) ----- src/CMakeLists.txt 9e84a8b9d427505a8babc79713ca41f1ec223a2a src/filetransfer-control.h PRE-CREATION src/filetransfer-control.cpp PRE-CREATION src/filetransfer-handler.h 53b710a0bec0bf5dd10e70a53c59b90112c5e4e8 src/filetransfer-handler.cpp 0e4624e46b4a702afa962dc3efcff37d4dae54ff src/main.cpp 19182dbadd3e8e043ffeb4cb870a84297a29853e Diff: http://git.reviewboard.kde.org/r/102306/diff Testing ------- Tried file transfers (just on my laptop) still exits when it is supposed to exit. Thanks, Daniele Elmo
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
