----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102636/ -----------------------------------------------------------
Review request for Telepathy and David Edmundson. Summary ------- Use Q_FOREACH instead of foreach Use Q_EMIT instead of emit Use Q_SIGNALS instead of signals Use Q_SLOTS instead of slots Diffs ----- adiumxtra-protocol-handler/chat-style-installer.cpp bf3e012c2393c973bf648d102afaa9547ea25717 adiumxtra-protocol-handler/emoticon-set-installer.cpp 7a7556463cfa641fad731bb733f582fcd1bce2b3 app/chat-tab.h 9b5fc59b88c233b86956b871499de94594220356 app/chat-window.h 5288e597fb855dcdbfd001b4928cdad415ef14c4 app/chat-window.cpp 1ef738fa81b0a1ca38a35252b76293a3f32f8f34 app/telepathy-chat-ui.h 42f522cc9d26e876fd22d6d7e17f28983df2dabf app/telepathy-chat-ui.cpp b5e99d7b39396357f95d9ebbd971a051b5a561d4 config/appearance-config.h 64029554807b76201170eca60158760e9c649966 config/behavior-config.h dd8cc3dd9ff34d080de4050c9db5b59f1f50d694 lib/adium-theme-view.h 0507128d585346a4556d247bb83de4e13105b2cb lib/channel-contact-model.h d0c2cb5e06ebe0dc52c2d9e9e2563c8e937c8fb6 lib/channel-contact-model.cpp 7887880ac9736b1769c5493c93d350b02067ef26 lib/chat-search-bar.h daf909f7c1d6456e65c269d5df4cd19a1435cacb lib/chat-search-bar.cpp 0659f93765c1fac69bc3e3806d36a332021eeef5 lib/chat-text-edit.h c643db21b76b259269fd9227fc3139325d69ba5e lib/chat-text-edit.cpp 1086e476f4371ec0e3b1e410a13b7a1860a472bb lib/chat-widget.h 7f4376422131231ce7f2502ce3d47142a4aed8fd lib/chat-widget.cpp 2e0d9b1b3b2c37d56a151202f6eb68ee0c145e49 lib/chat-window-style-manager.h 21efa90c318120877180ea7edcecbbbb6a99096f lib/chat-window-style-manager.cpp 815d6f255d4ea5e49b8b8f333d071cb774a8c39b Diff: http://git.reviewboard.kde.org/r/102636/diff Testing ------- builds Thanks, Daniele Elmo
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
