> On Sept. 19, 2011, 10 p.m., David Edmundson wrote: > > src/edit-account-dialog.cpp, line 105 > > <http://git.reviewboard.kde.org/r/102667/diff/1/?file=36492#file36492line105> > > > > The parameter should have a property called "secret" using this would > > be better. > > Also this is (hopefully) redundant in new code which won't be sending > > them anyway. > > > > Ship this for now, but have a look after the KWallet patch and see if > > this is actually still needed.
Actually this is just to filter out the password from the kDebug output, because I find really annoying that the password is printed on the screen. Another way to deal with this is just to remove the kDebug()... - Daniele Elmo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102667/#review6646 ----------------------------------------------------------- On Sept. 19, 2011, 4:38 p.m., Daniele Elmo Domenichelli wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102667/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2011, 4:38 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > * Hide password from debug output > * Reconnect account after editing only if required > * Enable editing account by double clicking on it > * Remove unused paramFound variable > > > Diffs > ----- > > src/KCMTelepathyAccounts/account-edit-widget.cpp > 0d7ab44862a8a642e5fb3d4e59cf499759d5c683 > src/accounts-list-model.h cc81c1e3e417eb8e6a35a4b8fb48205fea430452 > src/edit-account-dialog.cpp cb77d9a99defaf3d14af96a222fc5077cb79bdd1 > src/kcm-telepathy-accounts.cpp 8d0a1cb4816055b4ddcfa8c0a377d8f1b11c0e32 > > Diff: http://git.reviewboard.kde.org/r/102667/diff > > > Testing > ------- > > * Password is hidden > * Accepting edit account dialog without changing values doesn't reconnect > * Double clicking on an item on the view opens the edit file dialog > * Build warning removed > > > Thanks, > > Daniele Elmo > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
