> On Oct. 3, 2011, 11:48 a.m., David Edmundson wrote: > > src/config.cpp, line 36 > > <http://git.reviewboard.kde.org/r/102762/diff/1/?file=37809#file37809line36> > > > > Why not set parents on these? Then you don't have to delete them. > > Francesco Nwokeka wrote: > parents needed have to be QWidgets. The Plasma::Applet is not a QWidget. > That's why I don't set them and I have to delete the objects myself
> parents needed have to be QWidgets Are you Sure they don't need to be QObjects? Plasma::Applet is a QObject. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102762/#review7022 ----------------------------------------------------------- On Oct. 3, 2011, 2:44 p.m., Francesco Nwokeka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102762/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2011, 2:44 p.m.) > > > Review request for Telepathy and David Edmundson. > > > Description > ------- > > Moving the contactManagerPtr from the config class to the main applet > lightens the applet. This because we don't keep track of every change made in > the Tp model by creating the config object only when needed. Thus the models > for display too. > > > Diffs > ----- > > src/config.h 6d3e27d > src/config.cpp 9734a83 > src/telepathy-contact.h ce7632f > src/telepathy-contact.cpp 34ce6db > > Diff: http://git.reviewboard.kde.org/r/102762/diff/diff > > > Testing > ------- > > > Thanks, > > Francesco Nwokeka > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
