-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102782/#review7163
-----------------------------------------------------------

Ship it!


Few issues with the GlobalPresence class. 
Will update my version in the CL branch, and then you can fetch that.
Ship it when that's done.


global-presence.h
<http://git.reviewboard.kde.org/r/102782/#comment6260>

    LICENSE
    - remember to put the correct Author!



global-presence.cpp
<http://git.reviewboard.kde.org/r/102782/#comment6259>

    LICENSE
    



global-presence.cpp
<http://git.reviewboard.kde.org/r/102782/#comment6258>

    What sort of numpty left qDebug code in?


- David Edmundson


On Oct. 5, 2011, 1:42 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102782/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2011, 1:42 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> First integration of global presence handling into kded module. This will 
> make operations easier as it won't be necessary to iterate over all accounts 
> on every presence change, but unified interface will be used instead (same as 
> in contact list). Furthermore, this patch saves the last used presence to 
> ktelepathyrc, that can be picked by any component and restored (on contact 
> list starting for example).
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 143afef 
>   autoaway.h a95f49a 
>   autoaway.cpp 812ba97 
>   global-presence.h PRE-CREATION 
>   global-presence.cpp PRE-CREATION 
>   telepathy-module.h 815ee38 
>   telepathy-module.cpp 174cecf 
> 
> Diff: http://git.reviewboard.kde.org/r/102782/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

_______________________________________________
KDE-Telepathy mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-telepathy

Reply via email to