----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102776/#review7275 -----------------------------------------------------------
Ship it! Ship It! - David Edmundson On Oct. 12, 2011, 5:25 p.m., Dominik Schmidt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102776/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2011, 5:25 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > I'm sorry this patch got so massive, I spent 4 hours trying to split it up > and do a proper review request with no success :-( > > Anyways, you can take a look at my branch with more granular commits: > kde:clones/telepathy-text-ui/dschmidt/telepathy-text-ui gomental > > > Now to the patch: > It adds backlog functionality (currently a hardcoded amount of messages) to > the chat widget via telepathy-logger-qt4. I made it an optional dep cause > that lib is not released yet and I want to replace it with logs retrieved > from Nepomuk for 0.3. > > All logic interacting with that lib is encapsulated in the LogManager class, > so it will be easy to do that change. > > > Diffs > ----- > > cmake/modules/FindGIO.cmake PRE-CREATION > cmake/modules/FindGObject.cmake PRE-CREATION > cmake/modules/FindQtGLib.cmake PRE-CREATION > cmake/modules/FindTelepathyGlib.cmake PRE-CREATION > cmake/modules/FindTelepathyLogger.cmake PRE-CREATION > cmake/modules/FindTelepathyLoggerQt4.cmake PRE-CREATION > config/appearance-config.cpp 895040b > lib/CMakeLists.txt 801749e > lib/adium-theme-message-info.h d90112c > lib/adium-theme-message-info.cpp 545444d > lib/adium-theme-view.cpp 89879c8 > lib/chat-widget.h 0fe5d86 > lib/chat-widget.cpp 302d097 > lib/chat-window-style.h 32fe4fd > lib/chat-window-style.cpp 8242d90 > lib/logmanager.h PRE-CREATION > lib/logmanager.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/102776/diff/diff > > > Testing > ------- > > Yes, compiled with -DWITH_TelepathyLoggerQt4=ON and > -DWITH_TelepathyLoggerQt4=OFF and both builds work. > > > Screenshots > ----------- > > chat window with backlog > http://git.reviewboard.kde.org/r/102776/s/286/ > > > Thanks, > > Dominik Schmidt > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
