> On Oct. 26, 2011, 9:16 a.m., Daniele Elmo Domenichelli wrote: > > It's already marked as submitted but anyway a few more comments... > > 1) About thread-safety I suggest removing QObject as base class, since it > > looks like useless here, and using K_GLOBAL_STATIC. > > 2) Since it's quite probably that this class will end in a library, you > > should move the private members into a private class. > > 3) It should be into a namespace (KTelepathy for example, since it is used > > in other places) to avoid symbol problems
Good comments, thanks. Will work on them. Any opinions on the namespace? - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102959/#review7653 ----------------------------------------------------------- On Oct. 25, 2011, 9:20 a.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102959/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2011, 9:20 a.m.) > > > Review request for Telepathy. > > > Description > ------- > > Never display a dbus error again. > > > This addresses bug 282205. > http://bugs.kde.org/show_bug.cgi?id=282205 > > > Diffs > ----- > > error-dictionary.h 4a47536 > error-dictionary.cpp 401825a > > Diff: http://git.reviewboard.kde.org/r/102959/diff/diff > > > Testing > ------- > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
