----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103018/#review7828 -----------------------------------------------------------
This review request seems to be triply wrong from a licensing point of view. 1. Eike Hein's copyright notice is gone, and was replaced by "Copyright Przemek". 2. The files in this review request are GPL3+. Changing from GPL2+ (the original files' license) into GPL3+ is okay; but as far as I know, using GPL3+ (ie. forbidding GPL2) isn't allowed by the KDE license policy: http://techbase.kde.org/Policies/Licensing_Policy Even if you fix that, keeping the original copyright notice and going back to GPL2+: 3. telepathy-contact-list seems to be all LGPL2+. You can't relicense GPL2+ code into LGPL2+. The only way to import this URL matcher into telepathy-contact-list would be changing the project from LGPL2+ into GPL2+, or asking Eike Hein to relicense the URL matcher code from GPL2+ into LGPL2+ (or something even more liberal). *He* can do that, as the copyright holder of the code in question. (usual disclaimers apply: IANAL, speaking for myself and not for Eike, etc.) - Nicolas Alvarez On Nov. 1, 2011, 6:06 p.m., Przemek Czekaj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103018/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2011, 6:06 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Copied from Konversation common.h/cpp function to extract the url from data. > > > Diffs > ----- > > > Diff: http://git.reviewboard.kde.org/r/103018/diff/diff > > > Testing > ------- > > None. > > > Thanks, > > Przemek Czekaj > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
