----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103170/#review8318 -----------------------------------------------------------
code is fine, I just had a quick play with it in real life - only real observation is that when you select one of the main presences (without a status message (i.e available, away etc) it still has that text there. Which makes it super easy to accidentally create a new presence which is marked as available with the status message "Available". Maybe if there's no message when you go to editable, it should set the text to "". - David Edmundson On Nov. 17, 2011, 3:37 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103170/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2011, 3:37 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > If you click the combobox arrow button, a popup with list of presences will > be shown. If you click any other part of the combobox, it will turn itself > into editable one allowing you to input your own presence message, which is > set only if the user presses enter. When it loses focus, it is turned back > into standard combo. > > > Diffs > ----- > > global-presence-chooser.h c4e4302 > global-presence-chooser.cpp 56a066d > > Diff: http://git.reviewboard.kde.org/r/103170/diff/diff > > > Testing > ------- > > Works. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
