> On Nov. 22, 2011, 12:22 a.m., George Kiagiadakis wrote:
> > Ok, let's see. I'm ok for making it a library. That would happen anyway at
> > some point...
> >
> > What I see problematic here is the names. The whole naming scheme we use is
> > a bit confusing.
> >
> > The project is officially now "KDE-Telepathy".
> > Apps & tarballs (and l10n modules) are named "telepathy-kde-*".
> > The namespace used here and in other places is "KTelepathy" (which it's a
> > bit long imho... how about KTp?).
> > This library is called libtelepathykdecommoninternalsprivate (record for
> > biggest library name ever? :P), its cmake variables and export macros in
> > this patch are KTELEPATHY_* and installs stuff in
> > $prefix/include/telepathy-1.0/KTelepathy
> > The text-ui has a library called "ktelepathy_chat_lib", with export macros
> > "KDE_TELEPATHY_CHAT_LIB_*" and installs headers in
> > $prefix/include/KDETelepathy.
> > The nepomuk library that the other George is writing is called "ktelepathy"
> > and installs headers in $prefix/include/KTelepathy (and has no proper
> > export macro).
> >
> > Now, let's make a policy out of this...
> >
> > Btw, why the models have no namespace?
>
> Dario Freddi wrote:
> Whereas the naming concern is valid, consider the library at the moment
> is meant to remain private, so this is not an issue at the moment, and the
> name is intentionally confusing exactly to scare other people away from using
> it. When and if it will go public, of course we need to revise that part.
>
> KTp namespace sounds ok with me, will discuss on IRC now.
>
> The models have no namespace as changing namespace requires some changes
> to the Metatype handling, which historically doesn't play along well with
> them. However, that library is also going to change, as we want to export the
> models only and not the internal impl (items and such). When this happens,
> putting the exported classes in a namespace and the logic outside should be
> much easier.
>
> George Kiagiadakis wrote:
> Ok then. I'm still concerned about the include dir, though. Why use
> tp-qt4's include dir?
That's simply convenience. Since that variable always points to the base
telepathy dir includes (include/telepathy-1.0 for example), I thought it was a
good idea to use that directly. I can change to {include}/telepathy-1.0 if you
like
- Dario
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103183/#review8373
-----------------------------------------------------------
On Nov. 21, 2011, 7:54 p.m., Dario Freddi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103183/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2011, 7:54 p.m.)
>
>
> Review request for Telepathy and George Goldberg.
>
>
> Description
> -------
>
> This patch turns common-internals into a library. Here follows a shortlog of
> changes of what I did for making this happen:
>
> 264472c Add CMake magic for making the library build
> bb7e95b Now that everything has been put into a namespace, rename KPresence
> to Presence for consistency
> ad52ffe Export the classes
> b587540 Add KTelepathy namespace to base classes
> b3ee5f6 Fix all warnings
> 83b2a68 Enforce the use of QLatin1*
> 5c8fc85 Enforce the non-use of Qt keywords
>
> Missing:
> * Fix paths (so move all the source code in a KTelepathy/ subfolder) for
> fixing includes in header files when including from other applications. I
> didn't do that in the review since it would have screwed up the diff badly.
> * Port applications
>
> George, I know you are reluctant towards this change, but the situation with
> the current submodules is getting unsustainable, and since we aim towards
> moving KTelepathy to Extragear for 0.3, we need to fix that. The concern
> about BC is not a problem, since we'll handle the SONUMBER accordingly, and
> the library will still be private for internal use until we decide for
> something different.
>
>
> Diffs
> -----
>
> CMakeLists.txt PRE-CREATION
> circular-countdown.h 039ce75
> circular-countdown.cpp 0821e4c
> cmake/modules/COPYING-CMAKE-SCRIPTS PRE-CREATION
> cmake/modules/FindTelepathyQt4.cmake PRE-CREATION
> error-dictionary.h 3444539
> error-dictionary.cpp e3893e5
> global-presence.h d782c3e
> global-presence.cpp 61f1457
> kpresence.h 81e702f
> kpresence.cpp 609ac24
> ktelepathy-export.h PRE-CREATION
> models/CMakeLists.txt PRE-CREATION
> models/accounts-filter-model.h 8b55abb
> models/accounts-filter-model.cpp 0665800
> models/accounts-model-item.h e3748b7
> models/accounts-model-item.cpp d854d8e
> models/accounts-model.h 825f113
> models/accounts-model.cpp 21f14cb
> models/contact-model-item.h c69d12f
> models/contact-model-item.cpp 67de9fa
> models/groups-model-item.cpp cbe3da2
> models/groups-model.h ef9b28e
> models/groups-model.cpp e56dc2a
> models/proxy-tree-node.h ae123d1
> models/proxy-tree-node.cpp e413509
> models/tree-node.h 9f675ab
> models/tree-node.cpp f892d5a
> presence.h PRE-CREATION
> presence.cpp PRE-CREATION
> service-availability-checker.h 8883fe6
> service-availability-checker.cpp 9b9e1d5
> telepathy-handler-application.h 455463d
> telepathy-handler-application.cpp ce28c26
> text-parser.h 7790b14
> text-parser.cpp 510c2a5
> wallet-interface.h 629dbe1
>
> Diff: http://git.reviewboard.kde.org/r/103183/diff/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dario Freddi
>
>
_______________________________________________
KDE-Telepathy mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-telepathy
