> On Nov. 30, 2011, 7:33 p.m., David Edmundson wrote: > > app/chat-window.h, line 97 > > <http://git.reviewboard.kde.org/r/103296/diff/1/?file=42495#file42495line97> > > > > What on earth is going on with the documentation here. > > > > /** Description of the method */ > > void theMethod(); > > > > not below the line. > > > > If we ran this through doxygen it would make no sense. > > > > (tbh, this looks like the fault of an earlier person, I blame whoever > > made the text-ui)
It's actually not below, your reviewboard window is too narrow :P The comments are on the same line, indented as far as the longest method name in that block goes. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103296/#review8621 ----------------------------------------------------------- On Nov. 30, 2011, 2:13 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103296/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2011, 2:13 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > This is a finished patch of Alin's addition of combobox to the text-ui. All > credit goes to him. > > > Diffs > ----- > > app/chat-window.h 6cbc425 > app/chat-window.cpp d423965 > app/chatwindow.rc c24ddcc > lib/chat-widget.h 31f13d6 > lib/chat-widget.cpp 2971b67 > > Diff: http://git.reviewboard.kde.org/r/103296/diff/diff > > > Testing > ------- > > Works. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
