----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103338/#review8741 -----------------------------------------------------------
Ship it! I should reject this just for the patch you made me merge in Tp-Qt and came out to be useless!! :D Just kidding ofc, great you got around this. Just one small issue here. P.S.: Remember to add the relevant bug to the review just to keep things on track lib/chat-widget.cpp <http://git.reviewboard.kde.org/r/103338/#comment7341> This i18n is obscure. If the message is not locale-dependent, it should not be translated. If it is, a rather explanatory comment should be added lib/chat-widget.cpp <http://git.reviewboard.kde.org/r/103338/#comment7342> Same here - Dario Freddi On Dec. 5, 2011, 6:36 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103338/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2011, 6:36 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Make use of the new messageTypes method in TpQt4 and support sending and > receiving action messages. > > > Diffs > ----- > > lib/chat-widget.cpp 2971b67 > > Diff: http://git.reviewboard.kde.org/r/103338/diff/diff > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
