----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103398/#review8919 -----------------------------------------------------------
Nicely done, but after I reached the end of the review, I realized there's an easier (and probably preferred) way how to fix this - make FeedbackWidget derive from KMessageWidget and just reimplement those methods for setting setMessage, setTitle etc. In that way we can leave the original code in tact everywhere and still be ported to KMW. src/KCMTelepathyAccounts/account-edit-widget.h <http://git.reviewboard.kde.org/r/103398/#comment7420> Pretty headers src/KCMTelepathyAccounts/account-edit-widget.cpp <http://git.reviewboard.kde.org/r/103398/#comment7421> Pretty headers src/KCMTelepathyAccounts/parameter-edit-model.h <http://git.reviewboard.kde.org/r/103398/#comment7422> Pretty headers src/add-account-assistant.h <http://git.reviewboard.kde.org/r/103398/#comment7417> Use pretty headers if available; KMessageWidget src/add-account-assistant.cpp <http://git.reviewboard.kde.org/r/103398/#comment7423> I'm not sure if including "\n" in i18n is allowed, the docs says nothing about that, but advises against using formatting tags. So I'd say separate those two strings in two arguments, pretty much the way it was before. Since it keeps the format of "Title \n Message", it makes sense to keep these two separated for better flexibility. src/salut-details-dialog.h <http://git.reviewboard.kde.org/r/103398/#comment7418> Pretty headers src/salut-enabler.h <http://git.reviewboard.kde.org/r/103398/#comment7419> Pretty headers - Martin Klapetek On Dec. 12, 2011, 8:02 p.m., Dominik Cermak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103398/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2011, 8:02 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Replaced all occurrences of FeedbackWidget with KMessageWidget. > Also turned two Informative messages into Error messages to make it > consistent. > > > This addresses bug 283869. > http://bugs.kde.org/show_bug.cgi?id=283869 > > > Diffs > ----- > > src/KCMTelepathyAccounts/CMakeLists.txt 581edcf > src/KCMTelepathyAccounts/account-edit-widget.h 52dc89d > src/KCMTelepathyAccounts/account-edit-widget.cpp 14f1b75 > src/KCMTelepathyAccounts/feedback-widget.h e547857 > src/KCMTelepathyAccounts/feedback-widget.cpp 057456a > src/KCMTelepathyAccounts/parameter-edit-model.h 3b2b08b > src/KCMTelepathyAccounts/parameter-edit-model.cpp f461674 > src/add-account-assistant.h b85d44e > src/add-account-assistant.cpp 1c2e90d > src/salut-details-dialog.h 5a36adc > src/salut-details-dialog.cpp 46fb94c > src/salut-enabler.h 8a86133 > src/salut-enabler.cpp ca7a46e > > Diff: http://git.reviewboard.kde.org/r/103398/diff/diff > > > Testing > ------- > > > Screenshots > ----------- > > Old version with FeedbackWidget > http://git.reviewboard.kde.org/r/103398/s/367/ > New version with KMessageWidget > http://git.reviewboard.kde.org/r/103398/s/368/ > > > Thanks, > > Dominik Cermak > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
