> On Dec. 19, 2011, 11:47 a.m., Daniele Elmo Domenichelli wrote: > > This will conflict with my cumulative patch > > https://git.reviewboard.kde.org/r/103466 :P > > Anyway, let's get this in first, I will rebase mine later... > > > > A few comments:
So just ship yours as mine has no additional functionality. - Dominik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103453/#review9074 ----------------------------------------------------------- On Dec. 18, 2011, 5:25 p.m., Dominik Cermak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103453/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2011, 5:25 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Make the rename dialog modeless so that filetransfer handler doesn't crash > when canceling the transfer through the notification while the dialog is open. > > > This addresses bugs 283003 and 288559. > http://bugs.kde.org/show_bug.cgi?id=283003 > http://bugs.kde.org/show_bug.cgi?id=288559 > > > Diffs > ----- > > src/handle-incoming-file-transfer-channel-job.h > 9cc7ad9023e11f002cdd4ed373059e38c754ae3b > src/handle-incoming-file-transfer-channel-job.cpp > 0821081d1dbf8948a070fba157c35c5ca26a4fe9 > > Diff: http://git.reviewboard.kde.org/r/103453/diff/diff > > > Testing > ------- > > Canceling the filetransfer through the notification while the rename dialog > is open doesn't crash filetransfer handler. > > > Thanks, > > Dominik Cermak > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
