> On Dec. 21, 2011, 5:48 p.m., George Kiagiadakis wrote: > > KTp/wallet-interface.cpp, line 27 > > <http://git.reviewboard.kde.org/r/103491/diff/1/?file=44182#file44182line27> > > > > Now that's interesting... I guess we can't just change it, as users > > will lose their passwords... but still, it's ugly. > > Dario Freddi wrote: > Given the state of the software, we can do that, but we have to do it now. > > David Edmundson wrote: > This was a deliberate decision at the time (by DrDanz IIRC) as it meant > we had the correct icon automatically load in KWalletManager. > It was "kde-telepathy" for a while.
Hmm, any suggestions here then? Should we rename it, and if so, how? - Dario ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103491/#review9146 ----------------------------------------------------------- On Dec. 21, 2011, 6:02 p.m., Dario Freddi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103491/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2011, 6:02 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > As per title. > > > Diffs > ----- > > CMakeLists.txt 2476ba7 > KTelepathy/CMakeLists.txt 9a92e6d > KTelepathy/Models/CMakeLists.txt 32da52e > KTelepathy/Models/accounts-filter-model.h 9c799b1 > KTelepathy/Models/accounts-filter-model.cpp 859c673 > KTelepathy/Models/accounts-model-item.h 14692d7 > KTelepathy/Models/accounts-model-item.cpp a057714 > KTelepathy/Models/accounts-model.h 09c6c7f > KTelepathy/Models/accounts-model.cpp c2a78c3 > KTelepathy/Models/contact-model-item.h b22d059 > KTelepathy/Models/contact-model-item.cpp 5014568 > KTelepathy/Models/groups-model-item.h c994f3d > KTelepathy/Models/groups-model-item.cpp 9e8f07a > KTelepathy/Models/groups-model.h e38cbf0 > KTelepathy/Models/groups-model.cpp f576d1c > KTelepathy/Models/proxy-tree-node.h d6cfb36 > KTelepathy/Models/proxy-tree-node.cpp fb5674b > KTelepathy/Models/tree-node.h 7155b01 > KTelepathy/Models/tree-node.cpp f9413ce > KTelepathy/circular-countdown.h 10f1658 > KTelepathy/circular-countdown.cpp 4cbb896 > KTelepathy/error-dictionary.h 414fd97 > KTelepathy/error-dictionary.cpp d91bfe5 > KTelepathy/global-presence.h 194f8cc > KTelepathy/global-presence.cpp 4fe4407 > KTelepathy/ktelepathy-export.h 22bb37e > KTelepathy/presence.h 71e7c6e > KTelepathy/presence.cpp d291a81 > KTelepathy/service-availability-checker.h c2d7b83 > KTelepathy/service-availability-checker.cpp e1f7e51 > KTelepathy/telepathy-handler-application.h 64ab876 > KTelepathy/telepathy-handler-application.cpp 2e45c0f > KTelepathy/text-parser.h aae4672 > KTelepathy/text-parser.cpp dc4c57b > KTelepathy/wallet-interface.h 9c4eb27 > KTelepathy/wallet-interface.cpp 6e271fe > KTp/CMakeLists.txt PRE-CREATION > KTp/Models/CMakeLists.txt PRE-CREATION > KTp/Models/accounts-filter-model.h PRE-CREATION > KTp/Models/accounts-filter-model.cpp PRE-CREATION > KTp/Models/accounts-model-item.h PRE-CREATION > KTp/Models/accounts-model-item.cpp PRE-CREATION > KTp/Models/accounts-model.h PRE-CREATION > KTp/Models/accounts-model.cpp PRE-CREATION > KTp/Models/contact-model-item.h PRE-CREATION > KTp/Models/contact-model-item.cpp PRE-CREATION > KTp/Models/groups-model-item.h PRE-CREATION > KTp/Models/groups-model-item.cpp PRE-CREATION > KTp/Models/groups-model.h PRE-CREATION > KTp/Models/groups-model.cpp PRE-CREATION > KTp/Models/proxy-tree-node.h PRE-CREATION > KTp/Models/proxy-tree-node.cpp PRE-CREATION > KTp/Models/tree-node.h PRE-CREATION > KTp/Models/tree-node.cpp PRE-CREATION > KTp/circular-countdown.h PRE-CREATION > KTp/circular-countdown.cpp PRE-CREATION > KTp/error-dictionary.h PRE-CREATION > KTp/error-dictionary.cpp PRE-CREATION > KTp/global-presence.h PRE-CREATION > KTp/global-presence.cpp PRE-CREATION > KTp/ktp-export.h PRE-CREATION > KTp/presence.h PRE-CREATION > KTp/presence.cpp PRE-CREATION > KTp/service-availability-checker.h PRE-CREATION > KTp/service-availability-checker.cpp PRE-CREATION > KTp/telepathy-handler-application.h PRE-CREATION > KTp/telepathy-handler-application.cpp PRE-CREATION > KTp/text-parser.h PRE-CREATION > KTp/text-parser.cpp PRE-CREATION > KTp/wallet-interface.h PRE-CREATION > KTp/wallet-interface.cpp PRE-CREATION > Messages.sh 615a372 > > Diff: http://git.reviewboard.kde.org/r/103491/diff/diff > > > Testing > ------- > > Compiles > > > Thanks, > > Dario Freddi > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
