----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103502/ -----------------------------------------------------------
(Updated Dec. 22, 2011, 12:29 p.m.) Review request for Telepathy. Description ------- This has actually lots of libraries, so I named the main kcm one according to the kcm scheme, its internal library is now 'libktpaccountskcminternal', while the plugins are 'ktpaccountskcm_plugin_X.so', which I'm not sure about. Should I turn it to 'libktpaccountskcm_plugin_X.so' or 'libktpaccountskcmpluginX.so'? Diffs (updated) ----- CMakeLists.txt 2a9aef2 cmake/modules/FindKTelepathy.cmake c9aa9dc cmake/modules/FindKTp.cmake PRE-CREATION plugins/butterfly/CMakeLists.txt 26859c9 plugins/butterfly/kcmtelepathyaccounts_plugin_butterfly.desktop 3df354a plugins/butterfly/ktpaccountskcm_plugin_butterfly.desktop PRE-CREATION plugins/gabble/CMakeLists.txt 81ba67d plugins/gabble/kcmtelepathyaccounts_plugin_gabble.desktop 62c501c plugins/gabble/ktpaccountskcm_plugin_gabble.desktop PRE-CREATION plugins/haze/CMakeLists.txt dfedda5 plugins/haze/kcmtelepathyaccounts_plugin_haze.desktop f044014 plugins/haze/ktpaccountskcm_plugin_haze.desktop PRE-CREATION plugins/idle/CMakeLists.txt 3b91531 plugins/idle/kcmtelepathyaccounts_plugin_idle.desktop adf8078 plugins/idle/ktpaccountskcm_plugin_idle.desktop PRE-CREATION plugins/rakia/CMakeLists.txt bfa8da7 plugins/rakia/kcmtelepathyaccounts_plugin_rakia.desktop 906f1d6 plugins/rakia/ktpaccountskcm_plugin_rakia.desktop PRE-CREATION plugins/salut/CMakeLists.txt 80da74f plugins/salut/kcmtelepathyaccounts_plugin_salut.desktop 98ea8e3 plugins/salut/ktpaccountskcm_plugin_salut.desktop PRE-CREATION plugins/sunshine/CMakeLists.txt 0a08d7a plugins/sunshine/kcmtelepathyaccounts_plugin_sunshine.desktop aceac75 plugins/sunshine/ktpaccountskcm_plugin_sunshine.desktop PRE-CREATION src/CMakeLists.txt 60542b2 src/KCMTelepathyAccounts/CMakeLists.txt 581edcf src/KCMTelepathyAccounts/kcmtelepathyaccounts-accountuiplugin.desktop 76ec85c src/KCMTelepathyAccounts/ktpaccountskcminternal-accountuiplugin.desktop PRE-CREATION src/account-item.cpp 533cb6e src/add-account-assistant.cpp acd0a9c src/edit-account-dialog.cpp 96f3092 src/kcm-telepathy-accounts.cpp 55d2853 src/kcm_ktp_accounts.desktop PRE-CREATION src/kcm_telepathy_accounts.desktop cd20e22 src/salut-message-widget.cpp f419486 Diff: http://git.reviewboard.kde.org/r/103502/diff/diff Testing ------- Successfully created an account. Everything works. Thanks, Martin Klapetek
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
