> On Jan. 5, 2012, 7:40 p.m., David Edmundson wrote: > > src/KCMTelepathyAccounts/simple-profile-select-widget.cpp, line 155 > > <http://git.reviewboard.kde.org/r/103592/diff/2/?file=45761#file45761line155> > > > > Do we still need d->profileItem? > > > > We can just return d->profileListModel->itemForService(... directly > > We no longer have any of that duplication/double creation issue.
Good point, we don't need it in d, but in future we need a local variable when automagic package installation gets implemented. For now, no we don't need it. > On Jan. 5, 2012, 7:40 p.m., David Edmundson wrote: > > src/KCMTelepathyAccounts/profile-list-model.cpp, line 119 > > <http://git.reviewboard.kde.org/r/103592/diff/2/?file=45757#file45757line119> > > > > We tend to use 0 (that's a zero not a letter o) rather than NULL. > > > > No real difference just keeps consistency. done. - Florian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103592/#review9588 ----------------------------------------------------------- On Jan. 5, 2012, 3:23 p.m., Florian Reinhard wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103592/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2012, 3:23 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > When no connection manager installed, the KCM would show broken dialogs for > jabber, google-talk and facebook chat because of the shipped profile files. > > The patch makes the kcm module now check if the connection manager for the > required profile exists. > > > Diffs > ----- > > src/add-account-assistant.cpp 3f189b440ddf26af4092af6ac11e247838087254 > src/KCMTelepathyAccounts/simple-profile-select-widget.h > 88caa0a85d5bb5c22c975f712dc452391c158211 > src/KCMTelepathyAccounts/simple-profile-select-widget.cpp > 2cfd8d53ed16a463dbf7cb0ae31a4c8af515cad9 > src/KCMTelepathyAccounts/CMakeLists.txt > d886b452c7cdc7704627be002f390f8e6ff4d7bb > src/KCMTelepathyAccounts/profile-list-model.h > e3c7cddc17feb019f55ae7f8fcbeb040ea840e16 > src/KCMTelepathyAccounts/profile-list-model.cpp > 6c4b08a94deb3a36e09bc6f085ba4acfb68b4bcf > src/KCMTelepathyAccounts/profile-select-widget.h > 8f3ad2a47b3deb818da76d8a38c4884507440f3f > src/KCMTelepathyAccounts/profile-select-widget.cpp > be0d41fdb4761d04be16107b534714f8cb93a01b > > Diff: http://git.reviewboard.kde.org/r/103592/diff/diff > > > Testing > ------- > > clicked all buttons with no connection manager at all installed => > installation required > clicked all buttons with the required connection managers installed => > properties dialog > > > Thanks, > > Florian Reinhard > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
