> On Jan. 6, 2012, 5:39 p.m., Daniele Elmo Domenichelli wrote: > > src/add-account-assistant.cpp, line 171 > > <http://git.reviewboard.kde.org/r/103637/diff/1/?file=45808#file45808line171> > > > > I agree with George, moreover since not all the distributions use > > PackageKit, you should check if the PackageKit service is available and > > display a different message.
Good point, listing what's going to be installed should be there before clicking anything. And yes, same as for georges comment: if packagekit doesn't work/isn't there we should just list the packages the user should install. - Florian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103637/#review9613 ----------------------------------------------------------- On Jan. 6, 2012, 1 p.m., Florian Reinhard wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103637/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2012, 1 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > automagically install telepathy-gabble / -haze. > > needs kpackagekit installed. (not there by default for kubuntu, they patch > stuff to use qapt). > > We possibly want to add a cmake variable for the packagenames like kdenetwork > does. > > > Diffs > ----- > > src/add-account-assistant.cpp 3023cf9c63f8a2e5b32f88e4b633aa52680ca7c5 > > Diff: http://git.reviewboard.kde.org/r/103637/diff/diff > > > Testing > ------- > > Purged telepathy-gabble, installation was triggered. > > > Thanks, > > Florian Reinhard > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
