----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103629/#review9660 -----------------------------------------------------------
Not a real review, just one comment... lib/conversation-target.cpp <http://git.reviewboard.kde.org/r/103629/#comment7950> I don't know how many times you are going to call the avatar() method, but I think it could be better to load the image in onAvatarDataChanged() and just return it here. - Daniele Elmo Domenichelli On Jan. 9, 2012, 11:52 a.m., Lasath Fernando wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103629/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2012, 11:52 a.m.) > > > Review request for Telepathy and David Edmundson. > > > Description > ------- > > Right, I decided that I should have reviewed and/or merge what work I've done > so far rather than letting it pile up in its corner into a giant worthless > clump. > > To the people that haven't heard (or wasn't at woshibon), this is a chat > plasmoid that more or less behaves like facebook and google talk, except it > sits in your taskbar :) > > And in terms of feedback, at this stage I think design issues should take > priority over sane code because the main reason I'm doing this is because I > don't want to have to do any massive restructuring later on. > > And if things don't make sense, ask me (I didn't comment/document anything > well and I'm certainly too sleepy now ;) > > PS: All the code is in my scratch repo > http://quickgit.kde.org/?p=clones%2Ftelepathy-text-ui%2Ffernando%2Fqmlplugin.git&a=shortlog&h=refs/heads/qml_plugins2 > > > Diffs > ----- > > CMakeLists.txt d1cc185 > lib/CMakeLists.txt 5d39a62 > lib/conversation-que-manager.h PRE-CREATION > lib/conversation-que-manager.cpp PRE-CREATION > lib/conversation-target.h PRE-CREATION > lib/conversation-target.cpp PRE-CREATION > lib/conversation.h PRE-CREATION > lib/conversation.cpp PRE-CREATION > lib/conversations-model.h PRE-CREATION > lib/conversations-model.cpp PRE-CREATION > lib/messages-model.h PRE-CREATION > lib/messages-model.cpp PRE-CREATION > lib/qml-plugins.h PRE-CREATION > lib/qml-plugins.cpp PRE-CREATION > lib/qmldir PRE-CREATION > lib/telepathy-text-observer.h PRE-CREATION > lib/telepathy-text-observer.cpp PRE-CREATION > plasmoid/CMakeLists.txt PRE-CREATION > plasmoid/contents/ui/ChatWidget.qml PRE-CREATION > plasmoid/contents/ui/ConversationDelegate.qml PRE-CREATION > plasmoid/contents/ui/TextDelegate.qml PRE-CREATION > plasmoid/contents/ui/main.qml PRE-CREATION > plasmoid/metadata.desktop PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/103629/diff/diff > > > Testing > ------- > > Um.. yeah... about that... :/ > > > Thanks, > > Lasath Fernando > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
