----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103810/#review10168 -----------------------------------------------------------
Ship it! app/chat-window.cpp <http://git.reviewboard.kde.org/r/103810/#comment8361> Can this string be in the lib somewhere/somehow? It's going to cause problems later if it gets renamed (which sounds likely given our history) and we have to update it in multiple places. - David Edmundson On Jan. 28, 2012, 1:17 p.m., Daniele Elmo Domenichelli wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103810/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2012, 1:17 p.m.) > > > Review request for Telepathy, George Kiagiadakis and David Edmundson. > > > Description > ------- > > Use KTp::ServiceAvailabilityChecker to check if krfb is available > > see also ktp-common-internals/KTp/Models/contact-model-item.cpp > > > Diffs > ----- > > app/CMakeLists.txt 88a6571dba35eb5ac2339a7c1cb51d6b288972ed > app/chat-window.cpp 59db66db442dffbb3352ca1c66133f1c461d1b59 > > Diff: http://git.reviewboard.kde.org/r/103810/diff/diff > > > Testing > ------- > > > Thanks, > > Daniele Elmo Domenichelli > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
