----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103824/#review10200 -----------------------------------------------------------
Ship it! Just two little things. lib/logmanager.cpp <http://git.reviewboard.kde.org/r/103824/#comment8390> What is this semicolon for? lib/logmanager.cpp <http://git.reviewboard.kde.org/r/103824/#comment8391> IIRC kDebug() is preferred. - Dominik Cermak On Jan. 29, 2012, 5:13 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103824/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2012, 5:13 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Tidy code in the backlog retriever of the text UI, fix all crashes rather > than creating and deleting instances of "LogManager" throughout the code. > > > Diffs > ----- > > lib/chat-widget.cpp ce5cb29 > lib/logmanager.h 4e11086 > lib/logmanager.cpp 61484af > > Diff: http://git.reviewboard.kde.org/r/103824/diff/diff > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
