> On Jan. 29, 2012, 6:45 p.m., David Edmundson wrote: > > Screenshot: Dialog with roomlist > > <http://git.reviewboard.kde.org> > > > > "Search in rooms..." > > > > I don't think the "in" is needed, unless it actually searches inside > > the room. > > > > Also what's the rules on "...". In the case of buttons it means new > > window, not sure it has any meaning here. Discuss. > > > > > > > >
Searching for a contact inside of rooms indeed would be cool :-P Joking apart. You are right, it simply should be "Search rooms". About the "...", I took my inspiration from send-file. I considered the "..." as a prompt for the user to put some text in there, but that's a somewhat odd because it is already a clickMessage. - Dominik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103825/#review10205 ----------------------------------------------------------- On Jan. 29, 2012, 6:36 p.m., Dominik Cermak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103825/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2012, 6:36 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > This adds support for showing available rooms. You can query the default > server of the selected account or specify a server yourself. > The list shows if the room is password protected, how many persons are there, > the name and the description. > > Suggestions for a better design are welcome. > Maybe make the labels of the first to lineedits also a clickMessage? > > > This addresses bug 291711. > http://bugs.kde.org/show_bug.cgi?id=291711 > > > Diffs > ----- > > CMakeLists.txt e57d3895981c0d2b5a6f35e3e4265fca86e4ec28 > dialogs/join-chat-room-dialog.h d0aba22bba3f271294bcaeae4b0e2527d200ac87 > dialogs/join-chat-room-dialog.cpp 164f910aa7d06bab3ca3f7d9d472aa6d2d5ed09f > dialogs/join-chat-room-dialog.ui 6c64151b629139a69e21b85b09c7c57498f2cd8a > rooms-model.h PRE-CREATION > rooms-model.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/103825/diff/diff > > > Testing > ------- > > Tested with XMPP. > > > Screenshots > ----------- > > Dialog with roomlist > http://git.reviewboard.kde.org/r/103825/s/422/ > > > Thanks, > > Dominik Cermak > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
