> On Feb. 3, 2012, 1:31 p.m., Daniele Elmo Domenichelli wrote: > > lib/message-processor.cpp, line 51 > > <http://git.reviewboard.kde.org/r/103848/diff/2/?file=48646#file48646line51> > > > > Not sure if this makes a big difference, but before the "Escape filter" > > was the first executed, now it is the last
Yes, that makes a huge difference actually. Good spot. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103848/#review10316 ----------------------------------------------------------- On Feb. 3, 2012, 12:37 p.m., Lasath Fernando wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103848/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2012, 12:37 p.m.) > > > Review request for Telepathy and David Edmundson. > > > Description > ------- > > Create an extensible framework for dealing with incomming messages in > text-ui. This patch implements a MessageProcessor and 3 MessageFilters: Url > and emoticon parsers, as well as an image embedding plugin (for funsizes :). > Eventually these will be turned into actual plugins that are loaded at > runtime rather than being hardcoded. But for now, they just make David's code > cleaner. > > > Diffs > ----- > > lib/CMakeLists.txt 31dadd2 > lib/adium-theme-message-info.cpp c5e0dfc > lib/adium-theme-view.h be90d65 > lib/adium-theme-view.cpp a0e7ac1 > lib/chat-widget.cpp 75acef0 > lib/emoticon-filter.cpp PRE-CREATION > lib/escape-filter.cpp PRE-CREATION > lib/filters.h PRE-CREATION > lib/image-filter.cpp PRE-CREATION > lib/message-processor.h PRE-CREATION > lib/message-processor.cpp PRE-CREATION > lib/message.h PRE-CREATION > lib/message.cpp PRE-CREATION > lib/url-filter.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/103848/diff/diff > > > Testing > ------- > > Spammed meme images at david. He seemed to be happy and replied with lots of > smiley faces. > > > Thanks, > > Lasath Fernando > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
