----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103903/#review10450 -----------------------------------------------------------
Ship it! Perfect! I also agree with the KDE icon rather than the blank white (we know how it is with icons..). plugins/gabble/main-options-widget-kde-talk.cpp <http://git.reviewboard.kde.org/r/103903/#comment8568> If these default params are fetched from the profile file, I'd like to have a debug line here printing out the value it gets, because it can very easily break with a malformed profile etc, that way we'll at least know the profile file is damaged/edited/not correct. Just a small suggestion ;) - Martin Klapetek On Feb. 9, 2012, 12:07 p.m., Daniele Elmo Domenichelli wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103903/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2012, 12:07 p.m.) > > > Review request for Telepathy and David Edmundson. > > > Description > ------- > > Add profile for kde-talk and plugin to configure > > > I used as icon name "im-kde-talk" that does not exist, so until we get one we > will have the default white icon > > > This addresses bug 293660. > http://bugs.kde.org/show_bug.cgi?id=293660 > > > Diffs > ----- > > plugins/gabble/main-options-widget-kde-talk.ui PRE-CREATION > plugins/gabble/main-options-widget-kde-talk.h PRE-CREATION > plugins/gabble/main-options-widget-kde-talk.cpp PRE-CREATION > data/profiles/kde-talk.profile PRE-CREATION > plugins/gabble/CMakeLists.txt 327d5a5881611fc55dce81b86d9af261460561c6 > plugins/gabble/gabble-account-ui.cpp > 7a2fea321b8754a191f399ece29ba76dd95c803d > > Diff: http://git.reviewboard.kde.org/r/103903/diff/diff > > > Testing > ------- > > Account creation, editing and connection work > > > Thanks, > > Daniele Elmo Domenichelli > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
