-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103992/
-----------------------------------------------------------
Review request for Telepathy and David Edmundson.
Description
-------
Ok, I did quite a few little things, that I may as well get reviewed before I
push.
I made the delegate of the chatArea a Loader, which then picks different
Components based on messageType.
I created 3 such components
- IncomingDelegate
- OutgoingDelegate - I made these two separate because I wanted to make things
that the other person said stand out, so I wanted to make messages sent by you
a more subtle color. Unfortunately I couldn't find a Plasma::Theme color that
did quite that, so I'm probably going to make it an option to override the
color.
- ActionDelegate - so now the plasmoid supports action messages. i.e. the '/me
did something' style messages.
I made it group sequential messages together.
I also made it a QT::Tool window to stop it from appearing in the taskbar
This addresses bugs 293485, 293519 and 293984.
http://bugs.kde.org/show_bug.cgi?id=293485
http://bugs.kde.org/show_bug.cgi?id=293519
http://bugs.kde.org/show_bug.cgi?id=293984
Diffs
-----
plasmoid/declarative-plugin/messages-model.h eeeae20
plasmoid/declarative-plugin/messages-model.cpp 0070c83
plasmoid/declarative-plugin/qml-plugins.cpp b570055
plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ActionDelegate.qml PRE-CREATION
plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ChatWidget.qml 783e127
plasmoid/org.kde.ktp-chatplasmoid/contents/ui/IncomingDelegate.qml
PRE-CREATION
plasmoid/org.kde.ktp-chatplasmoid/contents/ui/OutgoingDelegate.qml
PRE-CREATION
plasmoid/org.kde.ktp-chatplasmoid/contents/ui/TextDelegate.qml db95451
plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml 0ca90cd
Diff: http://git.reviewboard.kde.org/r/103992/diff/
Testing
-------
Thanks,
Lasath Fernando
_______________________________________________
KDE-Telepathy mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-telepathy
