----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104168/#review11175 -----------------------------------------------------------
Ship it! Patch looks good to me and I hate current behaviour, so if you tested and it works, then ship it! - Daniele Elmo Domenichelli On March 6, 2012, 9:51 a.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104168/ > ----------------------------------------------------------- > > (Updated March 6, 2012, 9:51 a.m.) > > > Review request for Telepathy. > > > Description > ------- > > This reverts the click-to-set-message behavior of the presence chooser > combobox and adds a button to change the message. I wanted to add a 'Confirm' > button once in the edit mode, but I just couldn't position it on top of the > lineedit, so I left saving only on enter key press for now. See screenshot > (that has mouse over effect over the button, otherwise the button is flat, > ie. has no edges). > > > Diffs > ----- > > global-presence-chooser.h e57cfdc > global-presence-chooser.cpp d935f76 > > Diff: http://git.reviewboard.kde.org/r/104168/diff/ > > > Testing > ------- > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/104168/s/447/ > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
