----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104173/#review11178 -----------------------------------------------------------
Code is mostly fine, in fact all the code bits are fine, and I would have happily clicked "ship it!". Only thing I'm not sure about it that you don't store/load/check the account selected. So if I save a favourite from my IRC account on #kde-telepathy, then load this dialog again, only this time my jabber account is selected. I'll still see #kde-telepathy in my favourites, if I hit continue it won't work. I'm not sure if we want to make the favourites only show ones from the current account (might look weird), or select the correct account (a lot more risky IMHO, as the account might be deleted be offline, etc.) or something else entirely. rooms-model.cpp <http://git.reviewboard.kde.org/r/104173/#comment9008> .isValid() should check index < rowCount() so this isn't needed. - David Edmundson On March 6, 2012, 2:35 p.m., Dominik Cermak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104173/ > ----------------------------------------------------------- > > (Updated March 6, 2012, 2:35 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Now you can maintain a list of your favorite chatrooms. > These are saved in the general ktelepathyrc to use them for autoconnection > (not available yet, will work on it). > > To not clutter the dialog too much I introduced tabs. > > I'm wondering whether it would make sense to merge those two models > (RoomsModel and FavoriteRoomsModel) into one (with FavoriteRoomsModel as the > base for the new one). > > > This addresses bug 291711. > http://bugs.kde.org/show_bug.cgi?id=291711 > > > Diffs > ----- > > dialogs/join-chat-room-dialog.h b5f7c6773f6a73f5653995a559bfab39b085e089 > dialogs/join-chat-room-dialog.cpp 06d0a3ae0d9cbfcb2247dd2593f9a6616613db20 > dialogs/join-chat-room-dialog.ui bec08058e2ffd56255b0f6c7977980226e973390 > rooms-model.h 675ea4cbb02cef5d823b69b6e48b292d3b4b07cf > rooms-model.cpp 8a5cbb0b8fb0eaed8b30d3b516a574d231d7876e > > Diff: http://git.reviewboard.kde.org/r/104173/diff/ > > > Testing > ------- > > Adding and removing favorites. > After closing and reopening contact-list the favorites are still there. > > > Screenshots > ----------- > > favorites tab > http://git.reviewboard.kde.org/r/104173/s/448/ > query tab > http://git.reviewboard.kde.org/r/104173/s/449/ > > > Thanks, > > Dominik Cermak > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
