----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104360/#review11729 -----------------------------------------------------------
Ship it! I feels ya brah - Dario Freddi On March 22, 2012, 4:03 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104360/ > ----------------------------------------------------------- > > (Updated March 22, 2012, 4:03 a.m.) > > > Review request for Telepathy. > > > Description > ------- > > Fix typo in Q_FLAGS > > THE RAGE REVIEW. > This bug took me all of Tuesday night to work out. > Without it the flags can't work in QML, as the correct one isn't exposed. > > Lesson for everyone: > Q_FLAGS doesn't actually check you've given it a valid flag. > > > Also added an presenceIcon role to the model (for the contact list applet). I > don't really want to add more roles, but there was no other way sensible I > could think to get the icon in QML. (this is two commits in my code, just > post-review being stupid uploaded them both) > > > Diffs > ----- > > KTp/Models/accounts-filter-model.h 36f8288b0edcbd4f809b860cf54ab19dfe5ffddf > KTp/Models/accounts-model.h c86d8cfafad1e956f98f9111b54e8cb923926c98 > KTp/Models/accounts-model.cpp 13aaa4cb1e9f9a49ee40191163809795a96fc611 > KTp/Models/contact-model-item.cpp 50145688be749d0bbb83d814ce99f4f02ec387a8 > > Diff: http://git.reviewboard.kde.org/r/104360/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
