----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104510/#review12252 -----------------------------------------------------------
Ship it! Looks good. The //FUTURE part also sounds good. - Martin Klapetek On April 8, 2012, 12:30 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104510/ > ----------------------------------------------------------- > > (Updated April 8, 2012, 12:30 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > There's a bug in KDED code (which randomly sets you offline). It's hard to > fix a bug in complex code so I've rewritten it to be a lot simpler. Right now > it should be doing exactly the same thing, with exactly the same bug. (though > the cause is a bit clearer, and hopefully the fix is too) > > However fixing it should now be easier. It also makes the change to > "non-global presence" a bit easier for 0.5 > > Remove "unconnected" dbus signals being emitted (they were for an idea > that never really happened) > Removed the complex removing and adding things to a stack, just have a > constant list (of two items) and loop through them. > Remove the priority code, as that now happens when you order the plugin > list. > > I'd like anyone to review, but will only ship it after Martin confirms. Ping > me on IRC/GTalk if it doesn't make sense. > > > Diffs > ----- > > autoaway.cpp c4d282d > telepathy-kded-module-plugin.h 431a46b > telepathy-kded-module-plugin.cpp 418e96a > telepathy-module.h 05d8c38 > telepathy-module.cpp 955ceec > telepathy-mpris.cpp 543109c > > Diff: http://git.reviewboard.kde.org/r/104510/diff/ > > > Testing > ------- > > Ran it. Auto away works. Now playing works. > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
