----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104554/#review12363 -----------------------------------------------------------
This review has been submitted with commit 3c609cdec06060b2c6e41bf6fb8ec8a59925debb by Aleix Pol to branch master. - Commit Hook On April 12, 2012, 1:37 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104554/ > ----------------------------------------------------------- > > (Updated April 12, 2012, 1:37 a.m.) > > > Review request for Telepathy and David Edmundson. > > > Description > ------- > > Tries to address a few problems the chat view has and simplifies the code (a > tiny bit). > - just reduce opacity when the view is at the end. Having a scroll > flickering doesn't feel good and helps reduce the stress the scrollbar adds > in such a small UI when it's not needed. I set the opacity to 0.3 but maybe 0 > would be better, or not. Don't know. > - the chat has two behaviors: a browse mode where the user is looking into > the log and doesn't want to be distracted and the user is looking into the > newer things on the chat. This patch tries to improve the detection of the > current state by making it more relaxed. This way it won't happen that if you > write too fast, then everything's messed up. [1] > > Other than that, I tried to port the PlasmaWidgets.LineEdit -> > PlasmaComponents.TextField. It's not really possible because at 4.8 we can't > know when the user pressed "enter". I guess you want to release 0.4 to work > on 4.8 so this is not possible, I think. Maybe it should be backported? > > [1] I'm unsure why we need these both having the screen version, I'll leave > it up to the maintainers to decide what to do with this. > > > Diffs > ----- > > plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ChatWidget.qml 740cb34 > > Diff: http://git.reviewboard.kde.org/r/104554/diff/ > > > Testing > ------- > > talked with myself for a while, once again. a lot of "asd" (and permutations) > where written tonight. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
