----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104594/#review12434 -----------------------------------------------------------
global-presence-chooser.cpp <http://git.reviewboard.kde.org/r/104594/#comment9752> 'this' is implicit, does it really need to be specified here? global-presence-chooser.cpp <http://git.reviewboard.kde.org/r/104594/#comment9753> Shouldn't this be OR and not AND? (Presence is either Offline OR Invisible) - Rohan Garg On April 14, 2012, 3:01 a.m., moses alexander wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104594/ > ----------------------------------------------------------- > > (Updated April 14, 2012, 3:01 a.m.) > > > Review request for Telepathy. > > > Description > ------- > > Hi > > This is patch for https://bugs.kde.org/show_bug.cgi?id=295840 . I am able to > disallow editing of presence message when the user is Offline or Invisible. > > Comments and suggestions will be appreciated. > > > Diffs > ----- > > global-presence-chooser.cpp 67e2b34 > > Diff: http://git.reviewboard.kde.org/r/104594/diff/ > > > Testing > ------- > > > Thanks, > > moses alexander > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
