----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104651/#review12705 -----------------------------------------------------------
This review has been submitted with commit ba5f9c81328045103f88dfab0825a574d0396c34 by Aleix Pol to branch master. - Commit Hook On April 18, 2012, 12:59 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104651/ > ----------------------------------------------------------- > > (Updated April 18, 2012, 12:59 a.m.) > > > Review request for Telepathy. > > > Description > ------- > > - remove the spacing between contacts. It's not needed. > - PlasmaWidgets.LineEdit -> PlasmaComponents.TextField. > - There was a comment saying that this change would fix the focus problem. > FALSE. KWin doesn't put the focus on the chat dialog for some reason (try > pressing space, you'll see that the button you clicked is toggled). Good news > is that the correct activateWindow call is being made, so that we can sort it > out eventually. > > > Diffs > ----- > > plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ChatWidget.qml 30efb4d > plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml b39208c > > Diff: http://git.reviewboard.kde.org/r/104651/diff/ > > > Testing > ------- > > Not much, but works fine. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
