> On May 4, 2012, 8:07 a.m., Martin Klapetek wrote: > > src/main.cpp, line 76 > > <http://git.reviewboard.kde.org/r/104779/diff/5/?file=62500#file62500line76> > > > > ...and leave the new line here ;)
Actually i think that there are 2 newlines here, so removing one should be ok... - Daniele Elmo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104779/#review13403 ----------------------------------------------------------- On May 4, 2012, 7:34 a.m., Puneet Goyal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104779/ > ----------------------------------------------------------- > > (Updated May 4, 2012, 7:34 a.m.) > > > Review request for Telepathy and Daniele Elmo Domenichelli. > > > Description > ------- > > This patch makes use of Tp-Qt factories to set up the telepathy client > registrar in main.cpp > I have used the codebase at > http://quickgit.kde.org/index.php?p=kwhiteboard.git&a=summary > > > Diffs > ----- > > launcher/mainwindow.h 69d5c5f > launcher/mainwindow.cpp 02c28ff > src/kwhiteboard-handler.h f3c55d0 > src/kwhiteboard-handler.cpp d78b09e > src/main.cpp 7e721f3 > > Diff: http://git.reviewboard.kde.org/r/104779/diff/ > > > Testing > ------- > > I have tested it and it runs successfully. > > > Thanks, > > Puneet Goyal > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
