----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104887/#review13613 -----------------------------------------------------------
Ship it! Ship It! - David Edmundson On May 8, 2012, 8:27 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104887/ > ----------------------------------------------------------- > > (Updated May 8, 2012, 8:27 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > The overlay classes were massive mess, this severely tidies it up by merging > several classes together as they only derived themselves for no real purpose > and removes lots of unused or useless methods. Overall the code is much > simpler and cleaner now. And it fixes the crash. > > > This addresses bug 293886. > http://bugs.kde.org/show_bug.cgi?id=293886 > > > Diffs > ----- > > contact-delegate-overlay.h 2307044 > contact-delegate-overlay.cpp 4733cdd > contact-delegate.cpp 8c6aebe > contact-list-widget.cpp 73be93c > contact-overlays.h f232c5c > contact-overlays.cpp 4200b46 > contact-view-hover-button.h 4248987 > contact-view-hover-button.cpp fd411b2 > > Diff: http://git.reviewboard.kde.org/r/104887/diff/ > > > Testing > ------- > > Everything still works. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
